Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in x509 certificate handling. #461

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

dlorenc
Copy link
Member

@dlorenc dlorenc commented Oct 19, 2021

The CryptoPubKey function only returned the key value, but we should
retrieve it from the cert if set. This fixes the rest of #918.

Signed-off-by: Dan Lorenc [email protected]

Summary

Ticket Link

Fixes

Release Note


The CryptoPubKey function only returned the key value, but we should
retrieve it from the cert if set. This fixes the rest of sigstore#918.

Signed-off-by: Dan Lorenc <[email protected]>
@mattmoor
Copy link
Member

The test is consistent with the structure here, so if this works then hopefully we're good 🤞
https://github.com/sigstore/cosign/blob/7d2d51d6153e008607bfd5c4c1b5f0889d9d943e/pkg/cosign/tlog.go#L100

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bobcallaway bobcallaway merged commit 66e0ab1 into sigstore:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants