Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up EntryImpl interface #370

Merged
merged 15 commits into from
Jul 14, 2021
Merged

Conversation

bobcallaway
Copy link
Member

@loosebazooka this originated from your comment: #324 (review) where you rightly pointed out that the responsibility of the EntryImpl interface was not clear. This removes several of the methods from the interface definition shifting responsibility for basic verification to the Unmarshal method and fetching external resources & signature verification to the Canonicalize method.

This allows for more DRY addition of new PKI types, and stricter
type checking. This also allows for simpler enumeration of
supported PKI formats which will be used in further updates to
simplify the CLI codebase.

Signed-off-by: Bob Callaway <[email protected]>
This adds support for the alpine package format used by Alpine Linux,
which is the concatenation of three tgz files (signature, control data,
and then the actual package files).

Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
…; also use CliLogger throughout CLI

Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Make the interface clearer by removing ambiguity around who and when an
entry should have external objects fetched or validated.

Signed-off-by: Bob Callaway <[email protected]>
@cpanato cpanato added this to the 0.3.0 milestone Jul 14, 2021
Signed-off-by: Bob Callaway <[email protected]>
@dlorenc dlorenc merged commit 38d532d into sigstore:main Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants