Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build-container action #2247

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

javanlacerda
Copy link

@javanlacerda javanlacerda commented Oct 14, 2024

Summary

It improves the build container action by adding a tag with the format 0.YYYYMMDD.NNNN-ref.GITSHA.
It also adds the labels commit-hash and breaking-change labels to the container.

Example of workflow execution https://github.com/javanlacerda/rekor/actions/runs/11330765360/job/31509291276

Release Note

Documentation

@javanlacerda javanlacerda requested a review from a team as a code owner October 14, 2024 15:42
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.41%. Comparing base (488eb97) to head (d2c3a25).
Report is 210 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2247       +/-   ##
===========================================
- Coverage   66.46%   51.41%   -15.05%     
===========================================
  Files          92      192      +100     
  Lines        9258    19590    +10332     
===========================================
+ Hits         6153    10073     +3920     
- Misses       2359     8426     +6067     
- Partials      746     1091      +345     
Flag Coverage Δ
e2etests 49.58% <ø> (+2.02%) ⬆️
unittests 43.03% <ø> (-4.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments on the fulcio PR, let’s resolve them there first then copy over changes here

@haydentherapper haydentherapper marked this pull request as draft October 23, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants