Add metrics for index insertion #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new summary vector metric `rekor_index_storage_latency_summary` to enable tracking latency of entry insertion in the mysql or redis index storage backend. Since the index insertion is non-blocking, the existing API metrics are unable to measure its latency. However, the speed of insertion affects how fast the index is available to query, so it is relevant to rekor's overall performance. This new metric along with the existing API metrics will help give an clearer picture of rekor's index storage performance. Signed-off-by: Colleen Murphy <[email protected]>
cmurphy
force-pushed
the
index-insert-metrics
branch
from
2c129d2
to
e6a4441
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2015 +/- ##
===========================================
- Coverage 66.46% 48.81% -17.65%
===========================================
Files 92 80 -12
Lines 9258 6633 -2625
===========================================
- Hits 6153 3238 -2915
- Misses 2359 2989 +630
+ Partials 746 406 -340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
haydentherapper
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new summary vector metric
rekor_index_storage_latency_summaryto enable tracking latency of entry insertion in the mysql or redis index storage backend.Since the index insertion is non-blocking, the existing API metrics are unable to measure its latency. However, the speed of insertion affects how fast the index is available to query, so it is relevant to rekor's overall performance.
This new metric along with the existing API metrics will help give an clearer picture of rekor's index storage performance.
Summary
Release Note
Documentation