Remove go-playground/validator dependency from pkg/pki #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See sigstore/sigstore-go#23. It might seem silly, but this reduces the size of sigstore-go by over 1 MB. We're already using asaskevich/govalidator elsewhere in Rekor, so no new dependencies added. If we wanted to remove go-playground/validator entirely from Rekor (which would shrink rekor-cli by over 1 MB as well), we'd need additional work to rekor-cli/app/ files pflags.go and validate.go. Signed-off-by: Zach Steindler <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1817 +/- ##
==========================================
- Coverage 66.50% 66.48% -0.02%
==========================================
Files 90 90
Lines 9051 9047 -4
==========================================
- Hits 6019 6015 -4
Misses 2302 2302
Partials 730 730
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bobcallaway
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It might seem silly, but this reduces the size of sigstore-go by over 1 MB. See See sigstore/sigstore-go#23.
We're already using asaskevich/govalidator elsewhere in Rekor, so no new dependencies added.
If we wanted to remove go-playground/validator entirely from Rekor (which would shrink rekor-cli by over 1 MB as well), we'd need additional work to rekor-cli/app/ files pflags.go and validate.go.
Release Note
NONE
Documentation
N/A