Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct index creation #1708

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Correct index creation #1708

merged 1 commit into from
Sep 22, 2023

Conversation

sabre1041
Copy link
Contributor

Summary

Corrects an issue upon Trillian db schema creation where an index creation is not idempotent

Release Note

  • Ensure Trillian db creation for SequencedLeafMerkleIdx is idempotent

Signed-off-by: Andrew Block <[email protected]>
@sabre1041 sabre1041 requested a review from a team as a code owner September 22, 2023 12:55
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #1708 (994a4fa) into main (a05fc3d) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
+ Coverage   66.84%   66.85%   +0.01%     
==========================================
  Files          88       88              
  Lines        8850     8850              
==========================================
+ Hits         5916     5917       +1     
  Misses       2231     2231              
+ Partials      703      702       -1     
Flag Coverage Δ
e2etests 48.93% <ø> (ø)
unittests 47.59% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@cpanato cpanato merged commit 817f23e into sigstore:main Sep 22, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants