Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set min go version to 1.21 #1651

Merged
merged 1 commit into from
Aug 29, 2023
Merged

set min go version to 1.21 #1651

merged 1 commit into from
Aug 29, 2023

Conversation

bobcallaway
Copy link
Member

#1580 included context.WithCancel which is only available in go 1.21. our CI actions were already bumped for this, but when building rekor locally we should match.

Signed-off-by: Bob Callaway <[email protected]>
@bobcallaway bobcallaway requested a review from a team as a code owner August 29, 2023 13:00
@bobcallaway bobcallaway enabled auto-merge (squash) August 29, 2023 13:04
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1651 (bf39cff) into main (a9f538d) will decrease coverage by 17.99%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1651       +/-   ##
===========================================
- Coverage   66.93%   48.95%   -17.99%     
===========================================
  Files          88       88               
  Lines        8804     8804               
===========================================
- Hits         5893     4310     -1583     
- Misses       2213     3647     +1434     
- Partials      698      847      +149     
Flag Coverage Δ
e2etests 48.95% <ø> (+0.02%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 46 files with indirect coverage changes

@bobcallaway bobcallaway merged commit 2934605 into sigstore:main Aug 29, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants