-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Identities API #1611
Refactor Identities API #1611
Conversation
Instead of providing raw strings that are up to the client to determine how to parse, return typed structs. Encoded keys are included and should be parsed based on the returned type. Signed-off-by: Hayden Blauzvern <[email protected]>
FYI: TUF requires a new root because go-tuf dropped support for hex-encoded keys, as they were not conformant to the TUF spec. |
Codecov Report
@@ Coverage Diff @@
## main #1611 +/- ##
==========================================
- Coverage 67.07% 66.90% -0.18%
==========================================
Files 83 83
Lines 8441 8452 +11
==========================================
- Hits 5662 5655 -7
- Misses 2101 2118 +17
- Partials 678 679 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm minus one errant 🥔
also, since this changes a public API surface we should probably bump into a new minor release.
Signed-off-by: Hayden Blauzvern <[email protected]>
@bobcallaway Agreed on the minor bump. |
Instead of providing raw strings that are up to the client to determine how to parse, return typed structs. Encoded keys are included and should be parsed based on the returned type.
Summary
Release Note
Documentation