Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file based signer and password #1049

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Sep 13, 2022

Signed-off-by: Asra Ali [email protected]

Summary

  • feat: adds flag for specifying a file-based signer with a password, useful for testing

Fixes #1026

Release Note

Documentation

I did add unit testing for this: as far as an integration test, the best I did was spin it up locally with a cosign generated encrypted key pair and verify that I could get the public key and log info.

@asraa asraa requested a review from a team as a code owner September 13, 2022 21:17
@asraa
Copy link
Contributor Author

asraa commented Sep 13, 2022

cc @vaikas

@asraa asraa force-pushed the file-key branch 2 times, most recently from 0735c01 to c3f78dc Compare September 13, 2022 21:27
Signed-off-by: Asra Ali <[email protected]>

lint

Signed-off-by: Asra Ali <[email protected]>

fix go

Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali <[email protected]>
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --file-ca (or something flag) for taking in secret from files like Fulcio does.
4 participants