Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix harness tests @ main #1038

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

priyawadhwa
Copy link
Contributor

Failure on main: https://github.com/sigstore/rekor/runs/8255202947?check_suite_focus=true

git fetch origin isn't pulling in all version tags, it's only pulling up to v0.8.2. I wonder if it's because the remote is called something else. Instead of specifying the remote name, just pull in all tags.

From https://github.com/sigstore/rekor
 * [new branch]      add-tuf    -> origin/add-tuf
 * [new branch]      grpc       -> origin/grpc
 * [new branch]      swagger    -> origin/swagger
 * [new tag]         v0.1.0     -> v0.1.0
 * [new tag]         v0.1.1     -> v0.1.1
 * [new tag]         v0.2.0     -> v0.2.0
 * [new tag]         v0.3.0     -> v0.3.0
 * [new tag]         v0.4.0     -> v0.4.0
 * [new tag]         v0.5.0     -> v0.5.0
 * [new tag]         v0.6.0     -> v0.6.0
 * [new tag]         v0.[7](https://github.com/sigstore/rekor/runs/8255202947?check_suite_focus=true#step:6:8).0     -> v0.7.0
 * [new tag]         v0.[8](https://github.com/sigstore/rekor/runs/8255202947?check_suite_focus=true#step:6:9).0     -> v0.8.0
 * [new tag]         v0.8.1     -> v0.8.1
 * [new tag]         v0.8.2     -> v0.8.2
Also testing at HEAD at commit a6d36b8028ecdb4c047dde52b2[9](https://github.com/sigstore/rekor/runs/8255202947?check_suite_focus=true#step:6:10)a76b51b058b2f
v0.8.1 v0.8.2 a6d36b8028ecdb4c047dde52b29a76b51b058b2f

Signed-off-by: Priya Wadhwa [email protected]

Summary

Release Note

Documentation

`git fetch origin` isn't pulling in all version tags, it's only pulling up to v0.8.2. I wonder if it's because the remote is called something else. Instead of specifying the remote name, just pull in all tags.

Signed-off-by: Priya Wadhwa <[email protected]>
@priyawadhwa priyawadhwa requested a review from a team as a code owner September 8, 2022 17:52
@priyawadhwa priyawadhwa merged commit c60a678 into sigstore:main Sep 8, 2022
@priyawadhwa priyawadhwa deleted the harness-main branch September 8, 2022 19:30
@github-actions github-actions bot added this to the v1.0.0 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants