Code review comments

Signed-off-by: Priya Wadhwa <[email protected]>
sigstore · Jul 25, 2022 · 603cc15 · 603cc15
1 parent 5953a16
commit 603cc15
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -17,4 +17,3 @@ rekorServerImagerefs
 rekorCliImagerefs
 trillianServerImagerefs
 trillianSignerImagerefs
-logs
diff --git a/tests/rekor-harness.sh b/tests/rekor-harness.sh
@@ -50,7 +50,7 @@ function build_cli () {
     cli_version=$1
     current_branch=$(git rev-parse --abbrev-ref HEAD)
     git checkout $cli_version
-    go build -o rekor-cli ./cmd/rekor-cli
+    make rekor-cli
     git checkout $current_branch
 }
 
@@ -63,8 +63,8 @@ function run_tests () {
     go clean -testcache
     for test in $HARNESS_TESTS
     do
-        if ! REKORTMPDIR=$REKORTMPDIR go test -run $test -v -tags=e2e ./tests/ > logs ; then 
-            cat logs
+        if ! REKORTMPDIR=$REKORTMPDIR go test -run $test -v -tags=e2e ./tests/ > $REKORTMPDIR/logs ; then 
+            cat $REKORTMPDIR/logs
             docker-compose logs --no-color > /tmp/docker-compose.log
             exit 1
         fi