fallback to json default cfg path if yaml does not exist #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1810 +/- ##
==========================================
- Coverage 57.93% 50.19% -7.75%
==========================================
Files 50 70 +20
Lines 3119 4202 +1083
==========================================
+ Hits 1807 2109 +302
- Misses 1154 1858 +704
- Partials 158 235 +77 ☔ View full report in Codecov by Sentry. |
|
Will need to rebase once #1814 merges. |
|
Needs a rebase. |
Signed-off-by: Janine Olear <[email protected]>
miyunari
force-pushed
the
change_default_config
branch
from
d218862
to
53fc3e7
Compare
Sry @haydentherapper, just saw this and rebased it now 👍 |
cpanato
approved these changes
Oct 4, 2024
javanlacerda
pushed a commit
to javanlacerda/fulcio
that referenced
this pull request
Oct 8, 2024
Signed-off-by: Janine Olear <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1811
Summary
The PR #1720 has changed the default config path from
/etc/fulcio-config/config.jsonto/etc/fulcio-config/config.yaml. This caused problems with non-explicitly configured environments.Release Note
Check and fallback to default JSON config if the default YAML configuration file did not exist.
Documentation