Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs) adds pkcs11 docs #129

Merged
merged 9 commits into from
May 10, 2023

Conversation

ChrisJBurns
Copy link
Contributor

This aims to deprecate https://github.com/sigstore/cosign/blob/main/PKCS11.md

Signed-off-by: ChrisJBurns [email protected]

Signed-off-by: ChrisJBurns <[email protected]>
@netlify
Copy link

netlify bot commented Apr 16, 2023

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit e974533
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/645ab926b66e17000846ed0d
😎 Deploy Preview https://deploy-preview-129--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ChrisJBurns
Copy link
Contributor Author

We may want to find a different default image for this one also? instead of using dlorenc?

@ChrisJBurns ChrisJBurns changed the title choee(docs) adds pkcs11 docs chore(docs) adds pkcs11 docs Apr 16, 2023
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we confirmed this is up to date and these commands stil work?

@ChrisJBurns
Copy link
Contributor Author

@haydentherapper I've not followed the guide, I just worked on the assumption it was up to date. The last commit to the file was made by yourself, so unless you've got a reason to think it may have changed since then? If so I can give it a walk through?

@haydentherapper
Copy link
Contributor

I haven't run through it either, it's just be good to confirm all commands are up to date.

@ChrisJBurns
Copy link
Contributor Author

ChrisJBurns commented Apr 25, 2023

@haydentherapper I gave it a follow and realised that I haven't got the necessary libs installed to follow it fully and before I went away and installed them I checked on Slack (forgive my laziness 😄 ) and had a chat with @znewman01 around whether the docs are out of date and he mentioned that he doesn't know of a reason why they would be.

@haydentherapper
Copy link
Contributor

SG then!

znewman01
znewman01 previously approved these changes Apr 25, 2023
Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to upper case ID throughout and remove the reference to a specific username

content/en/cosign/pkcs11.md Outdated Show resolved Hide resolved
content/en/cosign/pkcs11.md Outdated Show resolved Hide resolved
content/en/cosign/pkcs11.md Outdated Show resolved Hide resolved
content/en/cosign/pkcs11.md Outdated Show resolved Hide resolved
content/en/cosign/pkcs11.md Outdated Show resolved Hide resolved
content/en/cosign/pkcs11.md Outdated Show resolved Hide resolved
content/en/cosign/pkcs11.md Outdated Show resolved Hide resolved
content/en/cosign/pkcs11.md Outdated Show resolved Hide resolved
Co-authored-by: ltagliaferri <[email protected]>
Signed-off-by: Chris Burns <[email protected]>
ChrisJBurns and others added 7 commits May 9, 2023 22:19
Co-authored-by: ltagliaferri <[email protected]>
Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]>
Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]>
Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]>
Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]>
Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]>
Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]>
Signed-off-by: Chris Burns <[email protected]>
@ChrisJBurns
Copy link
Contributor Author

@ltagliaferri Sounds good to me! Have committed your suggestions

@ltagliaferri ltagliaferri merged commit 4f84672 into sigstore:main May 10, 2023
@ChrisJBurns ChrisJBurns deleted the adds-pkcs11-docs branch May 11, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants