-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs) adds pkcs11 docs #129
Conversation
Signed-off-by: ChrisJBurns <[email protected]>
✅ Deploy Preview for docssigstore ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
We may want to find a different default image for this one also? instead of using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we confirmed this is up to date and these commands stil work?
@haydentherapper I've not followed the guide, I just worked on the assumption it was up to date. The last commit to the file was made by yourself, so unless you've got a reason to think it may have changed since then? If so I can give it a walk through? |
I haven't run through it either, it's just be good to confirm all commands are up to date. |
@haydentherapper I gave it a follow and realised that I haven't got the necessary libs installed to follow it fully and before I went away and installed them I checked on Slack (forgive my laziness 😄 ) and had a chat with @znewman01 around whether the docs are out of date and he mentioned that he doesn't know of a reason why they would be. |
SG then! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to upper case ID throughout and remove the reference to a specific username
Co-authored-by: ltagliaferri <[email protected]> Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]> Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]> Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]> Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]> Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]> Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]> Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: ltagliaferri <[email protected]> Signed-off-by: Chris Burns <[email protected]>
@ltagliaferri Sounds good to me! Have committed your suggestions |
This aims to deprecate https://github.com/sigstore/cosign/blob/main/PKCS11.md
Signed-off-by: ChrisJBurns [email protected]