fix: safer way to install google/ko #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Batuhan Apaydın <[email protected]>
cpanato
approved these changes
Oct 13, 2021
developer-guy
changed the title
|
There are other places that use the same curl, we should fix them before merging it, @erkanzileli and @Dentrax will give this a hand:
|
hectorj2f
approved these changes
Oct 13, 2021
Signed-off-by: Erkan Zileli <[email protected]> Co-authored-by: Batuhan Apaydın <[email protected]> Co-authored-by: Furkan Türkal <[email protected]>
developer-guy
changed the title
|
we are ready. lets merge this 🥳🚀 |
developer-guy
added a commit
to developer-guy/cosign
that referenced
this pull request
Oct 14, 2021
* fix: safer way to install google/ko Signed-off-by: Batuhan Apaydın <[email protected]> * fix: update other ko installations as 'go install' Signed-off-by: Erkan Zileli <[email protected]> Co-authored-by: Batuhan Apaydın <[email protected]> Co-authored-by: Furkan Türkal <[email protected]> Co-authored-by: Erkan Zileli <[email protected]> Co-authored-by: Furkan Türkal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın [email protected]
Summary
we can use the
go installwith theGOBINoption to install ko under/usr/local/binsafelly.QA Test Steps:
Ticket Link
Fixes #888
Release Note