Improve Kubernetes examples in docs and commands #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a Kubernetes section to the KMS document explaining how to generate a key pair and a general overview of how cosign interacts with secrets in the cluster. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit adds kubernetes examples to the help output of `cosign verify` and `cosign sign`. In addition, square and angled brackets used as placeholders in examples are modified to match in the output of both subcommands. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
puerco
changed the title
dlorenc
approved these changes
Aug 19, 2021
|
Welcome Puerco! |
|
Thank you so much for this @puerco 🎊🥳🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two commits to improve the examples of Kubernetes secrets in the cosign sign and verify commands, as well as the documentation:
Add Kubernetes KMS entry and fix README example
This commit adds a Kubernetes section to the KMS document explaining how
to generate a key pair and a general overview of how cosign interacts
with secrets in the cluster.
Add Kubernetes secrets examples to cosign sign|verify
This commit adds kubernetes examples to the help output of
cosign verifyandcosign sign.In addition, square and angled brackets used as placeholders in examples are modified to match the output of both subcommands.
Signed-off-by: Adolfo García Veytia (Puerco) [email protected]