Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore fixes #476

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Chore fixes #476

merged 2 commits into from
Jul 26, 2021

Conversation

hectorj2f
Copy link
Contributor

This PR attempts to fix two typos and normalize the sub-command descriptions. I hope these descriptions were not added on purpose. I found them a bit inconsistent between subcommands.

SUBCOMMANDS
  public-key         public-key gets a public key from the key-pair
  generate-key-pair  generate-key-pair generates a key-pair
  verify             Verify a signature on the supplied container image
  sign               Sign the supplied container image.
  generate           generate (unsigned) signature payloads from the supplied container image
  sign-blob          Sign the supplied blob, outputting the base64-encoded signature to stdout.
  verify-blob        Verify a signature on the supplied blob
  verify-dockerfile  Verify a signature on the base image specified in the Dockerfile
  upload             upload contains tools to upload artifacts to a registry
  download           download contains tools to download artifacts and attached artifacts in a registry
  attach             attach contains tools to attach artifacts to other artifacts in a registry

versus

SUBCOMMANDS
public-key          Gets a public key from the key-pair
generate-key-pair   Generates a key-pair
verify              Verify a signature on the supplied container image
sign                Sign the supplied container image.
attest              Attest the supplied container image.
generate            Generates (unsigned) signature payloads from the supplied container image
sign-blob           Sign the supplied blob, outputting the base64-encoded signature to stdout.
verify-attestation  Verify an attestation on the supplied container image
verify-blob         Verify a signature on the supplied blob
verify-dockerfile   Verify a signature on the base image specified in the Dockerfile
upload              Provides utilities for uploading artifacts to a registry
download            Provides utilities for downloading artifacts and attached artifacts in a registry
attach              Provides utilities for attaching artifacts to other artifacts in a registry

@dlorenc
Copy link
Member

dlorenc commented Jul 25, 2021

Thank you! This is great!

@cpanato cpanato added this to the v1.0.0 milestone Jul 26, 2021
@cpanato cpanato requested review from dekkagaijin and dlorenc and removed request for dekkagaijin July 26, 2021 07:13
@dekkagaijin
Copy link
Member

LGTM, please resolve the presubmit failure by signing off on your commits: https://github.com/sigstore/cosign/pull/476/checks?check_run_id=3155152516

Signed-off-by: Hector Fernandez <[email protected]>
@dekkagaijin dekkagaijin merged commit 1f9d3d9 into sigstore:main Jul 26, 2021
@hectorj2f hectorj2f deleted the chore_fixes branch July 27, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants