-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cosign copy --only for signatures #3904
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3904 +/- ##
==========================================
- Coverage 40.10% 36.35% -3.76%
==========================================
Files 155 203 +48
Lines 10044 12819 +2775
==========================================
+ Hits 4028 4660 +632
- Misses 5530 7585 +2055
- Partials 486 574 +88 ☔ View full report in Codecov by Sentry. |
7d23cfa
to
3c92f54
Compare
See https://github.com/sigstore/cosign/blob/main/cmd/cosign/cli/copy/copy.go#L192 requires to have value `sig` instead of `sign`. Also aligned the option docs order to align with the order of the example. https://github.com/sigstore/cosign/blob/main/cmd/cosign/cli/copy.go#L40 Signed-off-by: Marco Franssen <[email protected]>
3c92f54
to
ac48b3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add tests?
I propose to do that in follow up pr. There have been historically 0 tests on this command. |
We recognize that much of cmd/ is untested but we should use this opportunity to improve coverage. I'd recommend adding tests for the changed function, and refactoring if needed so you can have a more testable function. |
Well I only have limited time, so don't want to blow up the scope of this PR. I'm just a happy user of cosign doing my contribution, trying to improve things that I can do in the limited amount of time I have. To refactor tests and such I need much more time which I don't have right now. So I would appreciate at least the improvements in this PR can be merged. |
Summary
There is a bug in the
cosign copy
command for the deprecated flag, as well documentation is invalid for the CLI option.See
https://github.com/sigstore/cosign/blob/main/cmd/cosign/cli/copy/copy.go#L192
requires to have value
sig
instead ofsign
.Also aligned the option docs order to align with the order of the
example. https://github.com/sigstore/cosign/blob/main/cmd/cosign/cli/copy.go#L40
Release Note
Fixes the
cosign copy
command to have correct documentation and proper fallback implementation for the deprecated --sig-only commandline option.Documentation
N.A.