Reorganize the upload and attach CLI commands. #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for #368. Signed-off-by: Dan Lorenc <[email protected]>
dekkagaijin
reviewed
Jun 21, 2021
| @@ -125,21 +125,21 @@ The signature is passed via the -signature flag. | |||
| It can be a file: | |||
|
|
|||
| ```shell | |||
| $ cosign upload -signature file.sig dlorenc/demo | |||
| $ cosign attach signature -signature file.sig dlorenc/demo | |||
There was a problem hiding this comment.
can drop -signature in this case and just have 2 positionals
There was a problem hiding this comment.
I just went back and forth on this one and decided against it. -signature is long but two positionals is uglier
dekkagaijin
reviewed
Jun 21, 2021
dekkagaijin
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for #368.
Signed-off-by: Dan Lorenc [email protected]