-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add handling of keyless verification for all verify commands #3761
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3761 +/- ##
==========================================
- Coverage 40.10% 37.06% -3.04%
==========================================
Files 155 200 +45
Lines 10044 12280 +2236
==========================================
+ Hits 4028 4552 +524
- Misses 5530 7180 +1650
- Partials 486 548 +62 ☔ View full report in Codecov by Sentry. |
4ab0e21
to
97c5573
Compare
Verification: the script https://github.com/dmitris/cosign-keyless/blob/main/verify-blob.sh fails with the trunk's version of cosign: $ ./verify-blob.sh
Wrote signature to file README.md.sig
cosign verify-blob (with --certificate-chain):
Verified OK
cosign verify-blob (with --ca-roots):
Error: cert verification failed: x509: certificate signed by unknown authority. Check your TUF root (see cosign initialize) or set a custom root with env var SIGSTORE_ROOT_FILE
main.go:74: error during command execution: cert verification failed: x509: certificate signed by unknown authority. Check your TUF root (see cosign initialize) or set a custom root with env var SIGSTORE_ROOT_FILE but works with the version build in this PR's branch: $ COSIGN=$HOME/gh/sigstore/cosign/cosign ./verify-blob.sh
Wrote signature to file README.md.sig
/Users/dsavints/gh/sigstore/cosign/cosign verify-blob (with --certificate-chain):
Verified OK
/Users/dsavints/gh/sigstore/cosign/cosign verify-blob (with --ca-roots):
Verified OK Similarly with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far, as you mention to me, i would like to have some tests for those
b6ed504
to
c6094b2
Compare
fb59f93
to
339224b
Compare
Copy the handling of non-Fulcio keys from the verify to all other verify commands (verify-attestation, verify-blob, verify-blob-attestations). Fix sigstore#3759. Signed-off-by: Dmitry S. <[email protected]>
Signed-off-by: Dmitry S. <[email protected]>
Signed-off-by: Dmitry S. <[email protected]>
Signed-off-by: Dmitry S <[email protected]>
Signed-off-by: Dmitry S <[email protected]>
Signed-off-by: Dmitry S <[email protected]>
Signed-off-by: Dmitry S <[email protected]>
Signed-off-by: Dmitry S <[email protected]>
Signed-off-by: Dmitry S <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Signed-off-by: Dmitry S <[email protected]>
Summary
Copy the handling of non-Fulcio keys from the
verify
to all the other verify commands (verify-attestation
,verify-blob
,verify-blob-attestations
).Fix #3759.
Release Note
--ca-roots
/--ca-intermediates
parameters to theverify-attestation
,verify-blob
, andverify-blob-attestations
commands (in additionto
verify
)Documentation
TODO - create a corresponding https://github.com/sigstore/docs PR, in particular in https://docs.sigstore.dev/verifying/verify/#local-verifications need to mention:
The command-line help as in
cosign verify-blob --help
already mentions the new parameter even though they don't yet properly work until this change is merged and released.