Update cosign generate cmd to not include newline #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the newline will result in a payload and sha256sum that is equivalent to what you get with the --output-payload flag and inside the hashedrekordobj.data.hash.value field. Signed-off-by: Lily Sturmann <[email protected]>
haydentherapper
approved these changes
Nov 27, 2023
|
No concerns about this being a potentially breaking change, as this seems more like a bug. |
lkatalin
force-pushed
the
testing
branch
2 times, most recently
from
66ba14c
to
a473ede
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3393 +/- ##
=======================================
Coverage 30.23% 30.23%
=======================================
Files 155 155
Lines 9958 9958
=======================================
Hits 3011 3011
Misses 6497 6497
Partials 450 450 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3392
Summary
Please see #3392 for a description of the problem.
Removing the newline will result in a payload and sha256sum that is equivalent to what you get with the
--output-payloadflag and inside thehashedrekordobj.data.hash.valuefield.Release Note
I'm not sure if fixing this bug will be a breaking change for anyone relying on
cosign generateto output with specific formatting.Documentation
None