feat: add support outputting rekor response on signing #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Choudhary <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3248 +/- ##
==========================================
+ Coverage 30.35% 30.82% +0.47%
==========================================
Files 155 155
Lines 9845 9967 +122
==========================================
+ Hits 2988 3072 +84
- Misses 6410 6442 +32
- Partials 447 453 +6
|
haydentherapper
requested changes
Sep 18, 2023
Signed-off-by: Vishal Choudhary <[email protected]>
Signed-off-by: Vishal Choudhary <[email protected]>
Signed-off-by: Vishal Choudhary <[email protected]>
Signed-off-by: Vishal Choudhary <[email protected]>
Signed-off-by: Vishal Choudhary <[email protected]>
|
@haydentherapper I have added a test and updated the logic, can you please review it Besides, I cannot run/debug tests in |
haydentherapper
previously approved these changes
Oct 17, 2023
test/e2e_test.go
Outdated
| @@ -951,6 +951,51 @@ func TestRekorBundle(t *testing.T) { | |||
| must(verify(pubKeyPath, imgName, true, nil, ""), t) | |||
| } | |||
|
|
|||
| func TestRekorOutput(t *testing.T) { | |||
| // turn on the tlog | |||
| defer setenv(t, env.VariableExperimental.String(), "1")() | |||
There was a problem hiding this comment.
Can you remove, the experimental flag is no longer used?
Signed-off-by: Vishal Choudhary <[email protected]>
|
@haydentherapper Removed the flag |
haydentherapper
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #3110
Previously, there's no support for outputting a bundle with
cosign sign(code), onlysign-blob(code). This PR adds support for outputting rekor response on signing. This supports use-cases where a signer does not want to attach metadata immediately to the container.Release Note
Added support outputting rekor response on signing with
cosign signDocumentation