add -r option for recursively signing multi-arch images
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekkagaijin
force-pushed
the
recursive
branch
5 times, most recently
from
dff1687
to
a404d31
Compare
dlorenc
reviewed
May 13, 2021
cmd/cosign/cli/sign.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| for _, manifest := range idxManifest.Manifests { |
There was a problem hiding this comment.
I always forget - is it possible to create an image that recurses even further? An index of indexes?
There was a problem hiding this comment.
not iiuc @jonjohnsonjr
There was a problem hiding this comment.
Talked with him and apparently recursive indexes can exist 🤮
There was a problem hiding this comment.
walking the tree now
There was a problem hiding this comment.
it hurts me that the flag is recursive but the implementation is not
There was a problem hiding this comment.
your anguish sustains me ❤️
dekkagaijin
force-pushed
the
recursive
branch
6 times, most recently
from
af6c7de
to
2a7861e
Compare
Signed-off-by: Jake Sanders <[email protected]>
dlorenc
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jake Sanders [email protected]