Cleanup: Add Digest to the SignedEntity interface.
#2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2960 +/- ##
=======================================
Coverage 30.26% 30.26%
=======================================
Files 151 151
Lines 9469 9469
=======================================
Hits 2866 2866
Misses 6158 6158
Partials 445 445
|
🧹 We have worked around the absence of this in the core interface (while implemented in both `Signed{Entity,Image}`) a variety of places.
This allows us to clean up those workarounds downstream.
/kind cleanup
Signed-off-by: Matt Moore <[email protected]>
hectorj2f
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧹 We have worked around the absence of this in the core interface (while implemented in both
Signed{Entity,Image}) a variety of places.I will start cleaning those up after confirming adding it doesn't break anything in-tree.
/kind cleanup
Release Note
oci.SignedEntitynow requires aDigestmethod (which was already largely assumed because of the two implementations.Documentation