Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental warning from Fulcio/Rekor flags #2923

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

priyawadhwa
Copy link
Contributor

Summary

Release Note

Documentation

@haydentherapper
Copy link
Contributor

Just needs a doc regen

@priyawadhwa
Copy link
Contributor Author

thanks @haydentherapper ! could you re-approve?

@priyawadhwa priyawadhwa enabled auto-merge (squash) April 24, 2023 16:17
znewman01
znewman01 previously approved these changes Apr 24, 2023
hectorj2f
hectorj2f previously approved these changes Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #2923 (5ceec00) into main (dc101a1) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2923   +/-   ##
=======================================
  Coverage   30.33%   30.33%           
=======================================
  Files         151      151           
  Lines        9439     9439           
=======================================
  Hits         2863     2863           
  Misses       6134     6134           
  Partials      442      442           
Impacted Files Coverage Δ
cmd/cosign/cli/options/fulcio.go 0.00% <0.00%> (ø)
cmd/cosign/cli/options/oidc.go 0.00% <0.00%> (ø)
cmd/cosign/cli/options/rekor.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@priyawadhwa priyawadhwa changed the title Remove experimental warning from Fulcio flags Remove experimental warning from Fulcio/Rekor flags Apr 24, 2023
@priyawadhwa
Copy link
Contributor Author

Sorry everyone, there were a few more instances of this. I'll need another another lgtm, thank you!!

@priyawadhwa priyawadhwa merged commit dc22795 into sigstore:main Apr 24, 2023
@github-actions github-actions bot added this to the v1.14.0 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants