Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sget #2885

Merged
merged 1 commit into from
Apr 10, 2023
Merged

remove sget #2885

merged 1 commit into from
Apr 10, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 9, 2023

Summary

  • Removes the sget command for now, while the team refines the vision for the "sget" idea, how it will be manifested in code, and how we'll distribute it to users.
    Follow up of Remove sget command #1364

@cpanato cpanato mentioned this pull request Apr 9, 2023
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #2885 (6a45b32) into main (de8753b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2885   +/-   ##
=======================================
  Coverage   30.33%   30.33%           
=======================================
  Files         151      151           
  Lines        9439     9439           
=======================================
  Hits         2863     2863           
  Misses       6134     6134           
  Partials      442      442           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hectorj2f
hectorj2f previously approved these changes Apr 9, 2023
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Signed-off-by: cpanato <[email protected]>
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@znewman01 znewman01 merged commit a8f57b6 into sigstore:main Apr 10, 2023
@github-actions github-actions bot added this to the v1.14.0 milestone Apr 10, 2023
@cpanato cpanato deleted the remove-sget branch April 10, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants