Add warning to use digest instead of tags to other cosign commands #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/ui/warnings.go
Outdated
|
|
||
| const TagReferenceMessage string = `Image reference %s uses a tag, not a digest, to identify the image to sign. | ||
|
|
||
| This can lead you to sign a different image than the intended one. Please use a |
There was a problem hiding this comment.
Did you want to keep the indentation?
There was a problem hiding this comment.
thanks! bad copy paste
Signed-off-by: Priya Wadhwa <[email protected]>
priyawadhwa
force-pushed
the
discourage
branch
from
27af19d
to
ec45258
Compare
haydentherapper
approved these changes
Jan 24, 2023
hectorj2f
approved these changes
Jan 24, 2023
uralsemih
pushed a commit
to uralsemih/cosign
that referenced
this pull request
Jan 29, 2023
…igstore#2650) Signed-off-by: Priya Wadhwa <[email protected]> Signed-off-by: Priya Wadhwa <[email protected]>
Vlatombe
reviewed
Mar 14, 2023
Comment on lines
+43
to
+46
| if _, ok := srcRef.(name.Digest); !ok { | ||
| msg := fmt.Sprintf(ui.TagReferenceMessage, srcImg) | ||
| ui.Warnf(ctx, msg) | ||
| } |
There was a problem hiding this comment.
What would be the better recommendation to copy multi-arch images with signature if not using tag?
There was a problem hiding this comment.
Good point. I think that copy and save may have been collateral damage here.
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 24, 2023
…igstore#2650) Signed-off-by: Priya Wadhwa <[email protected]> Signed-off-by: Priya Wadhwa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2047 for 2.0
Signed-off-by: Priya Wadhwa [email protected]