Breaking change: attach signature and attach sbom must use STDIN to upload raw string #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2637 +/- ##
=======================================
Coverage 30.03% 30.03%
=======================================
Files 146 146
Lines 9283 9283
=======================================
Hits 2788 2788
Misses 6065 6065
Partials 430 430
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* attach signature --signature=/path/to/signature no longer uploads literal filepath if file does not exist * attach sbom --sbom=/path/to/sbom no longer uploads literal filepath if file does not exist To upload raw string, you shoud using STDIN and --signature=- / --sbom=- echo $SIGNATURE | cosign attach signature --signature=- $IMAGE_DIGEST echo $SBOM | cosign attach sbom --sbom=- $IMAGE_DIGEST Signed-off-by: mozillazg <[email protected]>
mozillazg
force-pushed
the
improve-sbom-signature-flag
branch
from
5deba6e
to
cad8d45
Compare
znewman01
approved these changes
Jan 17, 2023
|
@znewman01 Anything I can help with to get this PR merged? |
Sorry about that! I think I was waiting on CI to pass and then lost track of this PR. Feel free to ping after a couple days in the future if you're waiting on me |
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 24, 2023
…igstore#2637) * attach signature --signature=/path/to/signature no longer uploads literal filepath if file does not exist * attach sbom --sbom=/path/to/sbom no longer uploads literal filepath if file does not exist To upload raw string, you shoud using STDIN and --signature=- / --sbom=- echo $SIGNATURE | cosign attach signature --signature=- $IMAGE_DIGEST echo $SBOM | cosign attach sbom --sbom=- $IMAGE_DIGEST Signed-off-by: mozillazg <[email protected]>
znewman01
added a commit
to znewman01/sigstore-docs
that referenced
this pull request
Apr 28, 2023
This makes it much easier to follow along at home. Also: - deleted a few output lines (we were showing them inconsistently) - deleted `cosign attach signature --signature Qr883oPO...` (passing the signature directly) because that doesn't work any more: sigstore/cosign#2637 Signed-off-by: Zachary Newman <[email protected]>
znewman01
added a commit
to znewman01/sigstore-docs
that referenced
this pull request
Apr 28, 2023
This makes it much easier to follow along at home. Also: - deleted a few output lines (we were showing them inconsistently) - deleted `cosign attach signature --signature Qr883oPO...` (passing the signature directly) because that doesn't work any more: sigstore/cosign#2637 Signed-off-by: Zachary Newman <[email protected]>
ltagliaferri
pushed a commit
to sigstore/docs
that referenced
this pull request
Apr 29, 2023
This makes it much easier to follow along at home. Also: - deleted a few output lines (we were showing them inconsistently) - deleted `cosign attach signature --signature Qr883oPO...` (passing the signature directly) because that doesn't work any more: sigstore/cosign#2637 Signed-off-by: Zachary Newman <[email protected]>
ltagliaferri
added a commit
to sigstore/docs
that referenced
this pull request
Apr 29, 2023
* Use ttl.sh for signing_with_containers.md examples. This makes it much easier to follow along at home. Also: - deleted a few output lines (we were showing them inconsistently) - deleted `cosign attach signature --signature Qr883oPO...` (passing the signature directly) because that doesn't work any more: sigstore/cosign#2637 Signed-off-by: Zachary Newman <[email protected]> * Fix "Sign and upload a generated payload" example Signed-off-by: Zachary Newman <[email protected]> --------- Signed-off-by: Zachary Newman <[email protected]> Signed-off-by: ltagliaferri <[email protected]> Co-authored-by: ltagliaferri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1307
Summary
Release Note
attach signature --signature=<signature>no longer uploads literal filepath if the file<signature>does not existattach sbom --sbom=<sbom>no longer uploads literal filepath if the file<sbom>does not exist--signature=-/--sbom=-:Documentation