-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
insecure-skip-tlog-verify: rename and adapt the cert expiration check #2620
Conversation
Signed-off-by: Hector Fernandez <[email protected]>
Signed-off-by: Hector Fernandez <[email protected]>
3ec7863
to
a66fb00
Compare
Codecov Report
@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
- Coverage 30.14% 30.13% -0.01%
==========================================
Files 146 146
Lines 9252 9255 +3
==========================================
Hits 2789 2789
- Misses 6032 6035 +3
Partials 431 431
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a comment nit, looks good!
Signed-off-by: Hector Fernandez <[email protected]>
f3fca6f
closes: #2590
Summary
Based on the discussion in #2590, we decided to rename the flag from
insecure-skip-tlog-verify
toinsecure-ignore-tlog
. Likewise, we also decided to throw an error expecting a signed timestamp whenever users ignore the tlog validation and no timestamp-rfc3161 was present.Release Note
Documentation