Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation: deprecates IMPORT.md due to docs migration #2585

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

ChrisJBurns
Copy link
Contributor

@ChrisJBurns ChrisJBurns commented Jan 2, 2023

Deprecates IMPORT.md documentation due to migration into sigstore/docsas part of PR#54 and issue #822

Live Version: https://docs.sigstore.dev/cosign/import-keypair/

Signed-off-by: ChrisJBurns 29541485+ChrisJBurns@users.noreply.github.com

@ChrisJBurns
Copy link
Contributor Author

@znewman01

The deprecation note to the IMPORT.md docs that was added to sigstore/docs in sigstore/docs#54, as discussed here.

znewman01
znewman01 previously approved these changes Jan 2, 2023
Copy link
Contributor

@znewman01 znewman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could actually kill the text here since your link is live. Up to you, approving either way

@ChrisJBurns
Copy link
Contributor Author

@znewman01 Shall kill in that case. Will push up the change now

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Merging #2585 (c892868) into main (59921bb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2585   +/-   ##
=======================================
  Coverage   30.80%   30.80%           
=======================================
  Files         144      144           
  Lines        8736     8736           
=======================================
  Hits         2691     2691           
  Misses       5654     5654           
  Partials      391      391           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ChrisJBurns ChrisJBurns force-pushed the adds-docs-migration-note branch 2 times, most recently from 3fb7e29 to 94bacc7 Compare January 2, 2023 21:17
@ChrisJBurns ChrisJBurns changed the title note: Adds documentation migration note to IMPORT.md fix: removes IMPORT.md due to docs migration Jan 2, 2023
Copy link
Contributor

@znewman01 znewman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have been clearer.

I meant to kill the text of the file but leave the "note" you had that redirected users to the migrated content. I think we probably have a few old links to this page lying around.

Sorry for the runaround!

@ChrisJBurns
Copy link
Contributor Author

@znewman01

Ahhh, I see, no problemo, shall push up amendment in a jiffy

@ChrisJBurns ChrisJBurns force-pushed the adds-docs-migration-note branch from 94bacc7 to a2e1ae5 Compare January 2, 2023 21:38

Verified

This commit was signed with the committer’s verified signature.
ChrisJBurns Chris Burns
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns ChrisJBurns force-pushed the adds-docs-migration-note branch from a2e1ae5 to c892868 Compare January 2, 2023 21:41
@ChrisJBurns ChrisJBurns changed the title fix: removes IMPORT.md due to docs migration deprecation: deprecates IMPORT.md due to docs migration Jan 2, 2023
Copy link
Contributor

@znewman01 znewman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for your patience!

@znewman01 znewman01 merged commit 67596fe into sigstore:main Jan 3, 2023
@github-actions github-actions bot added this to the v1.14.0 milestone Jan 3, 2023
@ChrisJBurns ChrisJBurns deleted the adds-docs-migration-note branch January 3, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants