Change go module name to github.com/sigstore/cosign/v2 for Cosign 2.0 #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Priya Wadhwa <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2544 +/- ##
=======================================
Coverage 30.08% 30.08%
=======================================
Files 139 139
Lines 8607 8607
=======================================
Hits 2589 2589
Misses 5642 5642
Partials 376 376
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Priya Wadhwa <[email protected]>
cpanato
changed the title
cpanato
reviewed
Dec 14, 2022
| @@ -1,4 +1,4 @@ | |||
| module github.com/sigstore/cosign | |||
| module github.com/sigstore/cosign/v2 | |||
|
|
|||
| go 1.18 | |||
There was a problem hiding this comment.
should we bump this to 1.19? 1.20 is almost out and 1.18 will be deprecated
There was a problem hiding this comment.
I think that's smart but let's do it in a different PR
znewman01
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Priya Wadhwa [email protected]
This is required to build a 2.0 version by go modules, the original rc release failed with this error:
Release Note
Change go module name to github.com/sigstore/cosgn/v2 for Cosign 2.0