Fix timestamp verification, add verify-blob tests #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2527 +/- ##
==========================================
- Coverage 30.14% 30.11% -0.04%
==========================================
Files 139 139
Lines 8595 8597 +2
==========================================
- Hits 2591 2589 -2
- Misses 5629 5632 +3
- Partials 375 376 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
While adding unit tests for verify-blob with timestamping, I found that we try to verify with the current time if no bundle is provided, even if we have a timestamp. I cleaned up this function to check the timestamp time and bundle time if either are provided, and if neither is provided, check against the current time. I also added a mock client to clean up tests. I'll move this mock client over to the timestamp-authority repo. Signed-off-by: Hayden Blauzvern <[email protected]>
haydentherapper
force-pushed
the
tsa-tests
branch
from
8ec4637
to
e4d1d05
Compare
dlorenc
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding unit tests for verify-blob with timestamping, I found that we try to verify with the current time if no bundle is provided, even if we have a timestamp. I cleaned up this function to check the timestamp time and bundle time if either are provided, and if neither is provided, check against the current time.
I also added a mock client to clean up tests. I'll move this mock client over to the timestamp-authority repo.
Signed-off-by: Hayden Blauzvern [email protected]
Summary
Release Note
Documentation