Better feedback if specifying incompatible argument on cosign sign --attachment
#2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chaosinthecrd <[email protected]>
znewman01
previously approved these changes
Nov 11, 2022
Signed-off-by: chaosinthecrd <[email protected]>
|
hopefully that's good to go 😄 |
znewman01
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chaosinthecrd [email protected]
This is a tiny change, but when using the
cosign sign --attachmentflag, it didn't seem clear why I was getting an error back. Of course the reason why is that the only attachment string it will accept issbom, which is making me wonder whether at least temporarily this would be better as a boolean flag--sbom-attachmentuntil there are other attachment types.I have changed the error message, just as a suggestion as I feel it makes it more clear as to what is going on as opposed to