Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --offline flag to force offline verification #2427

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

priyawadhwa
Copy link
Contributor

Summary

Release Note

Documentation

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #2427 (e7f3160) into main (40fa54c) will increase coverage by 0.31%.
The diff coverage is 22.77%.

❗ Current head e7f3160 differs from pull request most recent head 7757789. Consider uploading reports for the commit 7757789 to get more accurate results

@@            Coverage Diff             @@
##             main    #2427      +/-   ##
==========================================
+ Coverage   30.12%   30.44%   +0.31%     
==========================================
  Files         136      136              
  Lines        8459     8400      -59     
==========================================
+ Hits         2548     2557       +9     
+ Misses       5582     5508      -74     
- Partials      329      335       +6     
Impacted Files Coverage Δ
cmd/cosign/cli/dockerfile.go 0.00% <0.00%> (ø)
cmd/cosign/cli/manifest.go 0.00% <0.00%> (ø)
cmd/cosign/cli/options/certificate.go 0.00% <0.00%> (ø)
cmd/cosign/cli/options/verify.go 0.00% <0.00%> (ø)
cmd/cosign/cli/verify.go 0.00% <0.00%> (ø)
cmd/cosign/cli/verify/verify.go 18.46% <0.00%> (-0.47%) ⬇️
cmd/cosign/cli/verify/verify_attestation.go 0.00% <0.00%> (ø)
cmd/cosign/cli/verify/verify_blob.go 52.34% <25.00%> (+5.93%) ⬆️
pkg/cosign/verify.go 36.64% <42.85%> (+2.17%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/cosign/verify.go Show resolved Hide resolved
pkg/cosign/verify.go Show resolved Hide resolved
test/e2e_test.go Outdated Show resolved Hide resolved
test/e2e_test.go Outdated Show resolved Hide resolved
Signed-off-by: Priya Wadhwa <[email protected]>
@priyawadhwa
Copy link
Contributor Author

@asraa ptal whenever you can! :)

Signed-off-by: Priya Wadhwa <[email protected]>
Copy link
Contributor

@znewman01 znewman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but will let someone else pull the trigger on approval

pkg/cosign/verify.go Show resolved Hide resolved
@priyawadhwa priyawadhwa merged commit bef33ec into sigstore:main Nov 14, 2022
@github-actions github-actions bot added this to the v1.14.0 milestone Nov 14, 2022
@priyawadhwa priyawadhwa deleted the offline branch November 14, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants