Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate --certificate-email flag. Make --certificate-identity and -… #2411

Merged
merged 51 commits into from
Dec 21, 2022
Merged

Deprecate --certificate-email flag. Make --certificate-identity and -… #2411

merged 51 commits into from
Dec 21, 2022

Commits on Nov 3, 2022

  1. Deprecate --certificate-email flag. Make --certificate-identity and -… 

    …-certificate-oidc-issuer required for verification.

--certificate-email is now an alias for --certificate-identity. Also removed some redundant subject/issuer checking.

Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    25e49e4 View commit details
    Browse the repository at this point in the history

  2. Make --cert-email and --cert-identity mutually exclusive 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    b7e1548 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Remove --certificate-email flag 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    8566156 View commit details
    Browse the repository at this point in the history

  2. docgen 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    9602e9d View commit details
    Browse the repository at this point in the history

  3. lint 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    21482bd View commit details
    Browse the repository at this point in the history

  4. lint 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    4f5d609 View commit details
    Browse the repository at this point in the history

  5. Enforce requiring --certificate-identity and --certificate-oidc-issue… 

    …r for verification.

Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f223f6e View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Move argument checks to Exec() functions. 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    e5e9636 View commit details
    Browse the repository at this point in the history

  2. Don't require cert-identity or cert-oidc-issuer in keyed mode 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8cc212f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:sigstore/cosign into flags 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    12cae1c View commit details
    Browse the repository at this point in the history

  4. fix mismerge 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    803a341 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Change e2e blob and attestation tests to use keys. 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    3babacb View commit details
    Browse the repository at this point in the history

  2. Add workflow_dispatch trigger to attestation e2e tests 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    4835f5f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:sigstore/cosign into flags

    @kpk47
    kpk47 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    3fc8332 View commit details
    Browse the repository at this point in the history

  4. fix e2e test 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    c21c197 View commit details
    Browse the repository at this point in the history

  5. typo 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    902b53e View commit details
    Browse the repository at this point in the history

  6. typo 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    6c11e62 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. debugging workflow 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    68ce699 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:sigstore/cosign into flags

    @kpk47
    kpk47 committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    032cc39 View commit details
    Browse the repository at this point in the history

  3. fix attest e2e test 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    5dd8f2b View commit details
    Browse the repository at this point in the history

  4. fix attest e2e test 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    357452f View commit details
    Browse the repository at this point in the history

  5. removing debug print statements 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    35a21e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. test e2e keyless 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    c4c04f2 View commit details
    Browse the repository at this point in the history

  2. remove flags to trigger error 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    a545b14 View commit details
    Browse the repository at this point in the history

  3. change sign_blob e2e test to use local bundles 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    61de5bc View commit details
    Browse the repository at this point in the history

  4. Add tests for missing flags 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    f30b015 View commit details
    Browse the repository at this point in the history

  5. typos 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    2f87646 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' of github.com:sigstore/cosign into flags 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    d2a12a3 View commit details
    Browse the repository at this point in the history

  7. typos 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    1c84341 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. Move error checking into CheckVerifyOptions 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    655fb48 View commit details
    Browse the repository at this point in the history

  2. unit test 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    fb1764a View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Merge branch 'main' of github.com:sigstore/cosign into flags 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    3a7b802 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Merge branch 'main' of github.com:sigstore/cosign into flags 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b0a121d View commit details
    Browse the repository at this point in the history

  2. Re-disable e2e sign-blob-test. It can't run on GHA 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    8bc1a06 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. debug verify attestation test 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    cc2fc0e View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Merge branch 'main' of github.com:sigstore/cosign into flags 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    7733f76 View commit details
    Browse the repository at this point in the history

  2. Fix verify-attestation args 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    a0857c1 View commit details
    Browse the repository at this point in the history

  3. debug attestation 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    2c59469 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. debug verify-blob args 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    15cfa8d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:sigstore/cosign into flags

    @kpk47
    kpk47 committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    1f35b49 View commit details
    Browse the repository at this point in the history

  3. fix sign-blob integration test; remove debug print statements 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    858ee99 View commit details
    Browse the repository at this point in the history

  4. add regexp flags 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    98e66d9 View commit details
    Browse the repository at this point in the history

  5. docgen 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    6868f71 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Merge branch 'main' of github.com:sigstore/cosign into flags

    @kpk47
    kpk47 committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    fc654cd View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. update test cert and enable sign-blob e2e test 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    f8431d9 View commit details
    Browse the repository at this point in the history

  2. Remove sign-blob e2e test from workflow. It requires human interaction 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    034855f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:sigstore/cosign into flags

    @kpk47
    kpk47 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    a756b95 View commit details
    Browse the repository at this point in the history

  4. re-enable sign-blob e2e test using GH credentials 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    45fd981 View commit details
    Browse the repository at this point in the history

  5. fix workflow permissions 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    04c940d View commit details
    Browse the repository at this point in the history

  6. re-disable sign-blob tests. Changing workflow permissions didn't help 

    Signed-off-by: kpk47 <[email protected]>
    @kpk47
    kpk47 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    e84a33d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of github.com:sigstore/cosign into flags

    @kpk47
    kpk47 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    820bf93 View commit details
    Browse the repository at this point in the history