Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attest-blob command #2286

Merged
merged 7 commits into from
Oct 12, 2022
Merged

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented Sep 27, 2022

Built on top of #1265, thank you mlieberman85!

This is just the signing piece, we will need cosign verify-attest-blob as well which I'll do in a follow-up PR.
Once that's in I'll add in the unit and integration tests!

mlieberman85 and others added 2 commits May 31, 2022 19:52
This mostly copies the functionality of image attestation and blob
signing.

Signed-off-by: Michael <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Attention: Patch coverage is 0% with 92 lines in your changes missing coverage. Please review.

Project coverage is 29.84%. Comparing base (d795dcb) to head (5b76402).
Report is 1045 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cosign/cli/attest_blob.go 0.00% 54 Missing ⚠️
cmd/cosign/cli/options/attest_blob.go 0.00% 37 Missing ⚠️
cmd/cosign/cli/commands.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2286      +/-   ##
==========================================
- Coverage   30.18%   29.84%   -0.34%     
==========================================
  Files         131      133       +2     
  Lines        8089     8181      +92     
==========================================
  Hits         2442     2442              
- Misses       5323     5415      +92     
  Partials      324      324              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Priya Wadhwa <[email protected]>
@priyawadhwa priyawadhwa force-pushed the sign-attestation-blob branch 2 times, most recently from de01a17 to 4c6cb43 Compare September 27, 2022 18:16
Signed-off-by: Priya Wadhwa <[email protected]>
@priyawadhwa priyawadhwa changed the title WIP: Add attest-blob command Add attest-blob command Oct 11, 2022
@vaikas
Copy link
Contributor

vaikas commented Oct 12, 2022

Thanks so much for doing this! Would it be possible to add an e2e test for this functionality like here (hopefully mainly copy&paste if we want a new test leg, or just add a new test case in the existing one (sign/verify) (not worrying about the now overbaked testfile name :) ):
https://github.com/sigstore/cosign/blob/main/.github/workflows/kind-verify-attestation.yaml#L91

I'd be happy to add this myself but might not get to it for day or twoish

@priyawadhwa
Copy link
Contributor Author

@vaikas would it be ok if i did it in a follow-up pr? my next one is gonna be for the verify-blob-attestation command so i think it'll be easier to include the test once we have both signing & verification!

@vaikas
Copy link
Contributor

vaikas commented Oct 12, 2022

Oh, absolutely, that's perfetto!

@priyawadhwa priyawadhwa merged commit 2223cc5 into sigstore:main Oct 12, 2022
@priyawadhwa priyawadhwa deleted the sign-attestation-blob branch October 12, 2022 20:40
@github-actions github-actions bot added this to the v1.14.0 milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants