Add '--cert-identity' flag to support subject alternate names for ver… #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ification. Signed-off-by: kpk47 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2278 +/- ##
==========================================
+ Coverage 29.02% 29.15% +0.12%
==========================================
Files 131 131
Lines 7872 7899 +27
==========================================
+ Hits 2285 2303 +18
- Misses 5275 5284 +9
Partials 312 312
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
You probably need to run |
znewman01
previously approved these changes
Sep 26, 2022
Signed-off-by: kpk47 <[email protected]>
kpk47
force-pushed
the
verify-identity
branch
from
ff02868
to
e3cf1a9
Compare
znewman01
previously approved these changes
Sep 26, 2022
|
Looks like you missed a few changes in the e2e_test, otherwise LGTM! |
kpk47
dismissed stale reviews from haydentherapper and znewman01
via
0cb04a9
|
@kpk47 can you add the DCO to your last commit? |
Signed-off-by: kpk47 <[email protected]>
kpk47
force-pushed
the
verify-identity
branch
from
0cb04a9
to
5eedb3d
Compare
znewman01
previously approved these changes
Oct 3, 2022
haydentherapper
previously approved these changes
Oct 3, 2022
…ification. Signed-off-by: kpk47 <[email protected]>
Signed-off-by: kpk47 <[email protected]>
Signed-off-by: kpk47 <[email protected]>
…-identity Signed-off-by: kpk47 <[email protected]>
|
@kpk47 You'll need to sign the DCO again. |
Signed-off-by: kpk47 <[email protected]>
znewman01
approved these changes
Oct 11, 2022
znewman01
added a commit
to znewman01/community
that referenced
this pull request
Oct 11, 2022
I do a [whole bunch of reviewing for Cosign](https://github.com/sigstore/cosign/pulls?q=is%3Apr++commenter%3Aznewman01) and get CC'd in [pretty frequently](https://github.com/sigstore/cosign/pulls?q=is%3Apr+mentions%3Aznewman01) but wind up needing a second reviewer in every case. Would be nice to avoid that (so contributors [don't get stuck](sigstore/cosign#2278)). Signed-off-by: Zack Newman <[email protected]>
priyawadhwa
pushed a commit
to sigstore/community
that referenced
this pull request
Oct 11, 2022
I do a [whole bunch of reviewing for Cosign](https://github.com/sigstore/cosign/pulls?q=is%3Apr++commenter%3Aznewman01) and get CC'd in [pretty frequently](https://github.com/sigstore/cosign/pulls?q=is%3Apr+mentions%3Aznewman01) but wind up needing a second reviewer in every case. Would be nice to avoid that (so contributors [don't get stuck](sigstore/cosign#2278)). Signed-off-by: Zack Newman <[email protected]> Signed-off-by: Zack Newman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ification.
Summary
This PR adds the '--cert-identity' flag for supporting SANs during verification. This change is working towards #2056, but does not fix it completely.
Fixes #1964
Release Note
Added support for certificate Subject Alternate Names during verification flow.
Documentation
N/A, though this flag will need documenting if/when it completely replaces --cert-email.