use updated device flow logic with PKCE #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, let's get the updated dex rolled out then we can merge this and release. |
dlorenc
previously approved these changes
Aug 16, 2022
Signed-off-by: Bob Callaway <[email protected]>
bobcallaway
force-pushed
the
device_flow
branch
from
f28bc3f to
78b6c81
Compare
|
prod is live with v2.33.0 and I've verified this again against prod. just rebased and then this should be good to go. |
SGTM, can merge when tests pass |
dlorenc
approved these changes
Aug 16, 2022
cldmnky
pushed a commit
to cldmnky/cosign
that referenced
this pull request
Aug 21, 2022
Signed-off-by: Bob Callaway <[email protected]> Signed-off-by: Bob Callaway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need the updated Dex to roll from staging to prod, but I have locally verified this PR works in staging (which has the updated dex instance):
COSIGN_EXPERIMENTAL=1 setsid ./cosign sign-blob --rekor-url=https://rekor.sigstage.dev --fulcio-url=https://fulcio.sigstage.dev --oidc-issuer=https://oauth2.sigstage.dev/auth --insecure-skip-verify README.md < /dev/nullFixes: #2104
Signed-off-by: Bob Callaway [email protected]