Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix blob verification output with sharded rekor tlogs #2157

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Aug 12, 2022

Signed-off-by: Asra Ali [email protected]

Summary

See sigstore/sigstore-python#184 (comment)

When verifying blobs that were placed on sharded rekor instances (staging), the blob verification outputs the local log-index.

For e.g.

$ SIGSTORE_REKOR_PUBLIC_KEY=rekor.staging.pub COSIGN_EXPERIMENTAL=1 ./cosign verify-blob --signature python.sig --cert python-cert.pem --rekor-url https://rekor.sigstage.dev python-readme.md 
used alt pubkey
tlog entry verified with uuid: 3b5007afc2bb375d4078ad93e72537c9c3e8e1a21556d716cac7ee06b544950c index: 71
Verified OK

This corresponds to log index 532.

$ ./rekor get --uuid 3b5007afc2bb375d4078ad93e72537c9c3e8e1a21556d716cac7ee06b544950c --rekor_server https://rekor.sigstage.dev --format json | jq -r '.LogIndex'
532

This is because InclusionProof returns the "local" log index.

Release Note

Documentation

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #2157 (29f290b) into main (7d80bc0) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2157   +/-   ##
=======================================
  Coverage   26.23%   26.23%           
=======================================
  Files         130      130           
  Lines        7617     7617           
=======================================
  Hits         1998     1998           
  Misses       5362     5362           
  Partials      257      257           
Impacted Files Coverage Δ
cmd/cosign/cli/verify/verify_blob.go 9.72% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Asra Ali <[email protected]>

oops

Signed-off-by: Asra Ali <[email protected]>
@asraa asraa force-pushed the use-correct-log-index branch from 15f4d30 to 29f290b Compare August 12, 2022 22:59
@dlorenc dlorenc merged commit 481c2d2 into sigstore:main Aug 13, 2022
@github-actions github-actions bot added this to the v1.11.0 milestone Aug 13, 2022
cldmnky pushed a commit to cldmnky/cosign that referenced this pull request Aug 21, 2022
Signed-off-by: Asra Ali <[email protected]>

oops

Signed-off-by: Asra Ali <[email protected]>

Signed-off-by: Asra Ali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants