add flag to allow skipping upload to transparency log #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we use cosign extensively with a private registry, and would like to streamline the signing process to bypass the prompt to skip uploading to a the transparency log with a private registry. Signed-off-by: Kenny Leung <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2089 +/- ##
==========================================
- Coverage 26.33% 26.29% -0.05%
==========================================
Files 129 129
Lines 7564 7577 +13
==========================================
Hits 1992 1992
- Misses 5317 5330 +13
Partials 255 255
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: Kenny Leung <[email protected]>
Signed-off-by: Kenny Leung <[email protected]>
Signed-off-by: Kenny Leung <[email protected]>
cpanato
reviewed
Jul 22, 2022
cmd/cosign/cli/options/attest.go
Outdated
| @@ -75,4 +76,7 @@ func (o *AttestOptions) AddFlags(cmd *cobra.Command) { | |||
|
|
|||
| cmd.Flags().BoolVarP(&o.SkipConfirmation, "yes", "y", false, | |||
| "skip confirmation prompts for non-destructive operations") | |||
|
|
|||
| cmd.Flags().BoolVar(&o.TlogUpload, "tlog_upload", true, | |||
There was a problem hiding this comment.
i think it should match the other flags with composed name
for example the --no-upload then should be --tlog-upload
There was a problem hiding this comment.
thanks for the comment.
renamed to --no-tlog-upload, as the --upload flag refers to uploading signatures and not tlog.
Signed-off-by: Kenny Leung <[email protected]>
Signed-off-by: Kenny Leung <[email protected]>
Signed-off-by: Kenny Leung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add flag to allow skipping upload to transparency log
we use cosign extensively with a private registry, and would like to
streamline the signing process to bypass the prompt to skip uploading to
a the transparency log with a private registry.
Signed-off-by: Kenny Leung [email protected]
Release Note
add flag to allow skipping upload to transparency log
usage
cosign sign --key cosign.key --tlog_upload=false <IMAGE>to skip uploading to transparency logDocumentation
Yes, users can explicit decline upload to transparency log by passing the flag
--tlog_upload=falseflag. the--forceflag takes priority if both are specified.