-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OIDC test #2050
Fix OIDC test #2050
Conversation
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
…lid for 10 years Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it uses https://rekor.sigstore.dev/api/v1/log/entries
should we point to the staging env?
+1! I think it would be good to test against more recent versions of rekor before we update prod |
Signed-off-by: cpanato <[email protected]>
ok, we can do it in a follow up, then we can validate if this is working as expected :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2050 +/- ##
=======================================
Coverage 26.22% 26.22%
=======================================
Files 128 128
Lines 7539 7539
=======================================
Hits 1977 1977
Misses 5307 5307
Partials 255 255 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Summary
The test was missing some new flags and also the certificate that we use for self signing expired.
This PR update/fix the following things:
test execution in the forked repo:
Release Note
NONE
Documentation
NONE