Use cosign.ConfirmPrompt more consistently #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also unexport some needlessly exported consts in cli/fulcio/fulcio.go -- these should be implemented via sigstore/sigstore. Signed-off-by: Jason Hall <[email protected]>
dlorenc
approved these changes
Jun 30, 2022
| @@ -27,5 +27,6 @@ var _ Interface = (*CleanOptions)(nil) | |||
| func (c *CleanOptions) AddFlags(cmd *cobra.Command) { | |||
| c.Registry.AddFlags(cmd) | |||
| cmd.Flags().StringVarP(&c.CleanType, "type", "", "all", "a type of clean: <signature|attestation|sbom|all> (default: all)") | |||
| // TODO: Rename to --skip-confirmation for consistency? | |||
There was a problem hiding this comment.
it makes sense a lot to me, may I open an issue for this? @imjasonh
There was a problem hiding this comment.
Sure! I think we'll probably want --force to continue to exist for 1+ release, with a warning that it's renamed to --skip-confirmation, and use --force's value to set o.SkipConfirmation. If both are set and they disagree, then fail. Does that sound right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also unexport some needlessly exported consts in cli/fulcio/fulcio.go --
these should be implemented via sigstore/sigstore.
Signed-off-by: Jason Hall [email protected]
Followups from #2018
@haydentherapper