Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1378 create new attestation signature in replace mode if not existent #2014

Merged

Conversation

Syquel
Copy link
Contributor

@Syquel Syquel commented Jun 22, 2022

Summary

Currently it is not possible to use cosign attest with the --replace option if either the attestation artifact or the attestation predicate does not exist.
Adds the ability to cosign attest with the --replace option to create new attestation artifacts or append new predicates to an existing attestation artifact.

Ticket Link

Fixes #1378

Release Note

Fixed the ability of `cosign attest` with the `--replace` option to create new attestations

@Syquel Syquel force-pushed the bugfix/1378-fix-replace-does-not-create branch from afff170 to d4616e4 Compare June 22, 2022 08:34
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #2014 (d4616e4) into main (76184c4) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2014   +/-   ##
=======================================
  Coverage   26.16%   26.16%           
=======================================
  Files         127      127           
  Lines        7422     7422           
=======================================
  Hits         1942     1942           
  Misses       5225     5225           
  Partials      255      255           
Impacted Files Coverage Δ
pkg/oci/mutate/mutate.go 81.28% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76184c4...d4616e4. Read the comment docs.

@Syquel
Copy link
Contributor Author

Syquel commented Jun 28, 2022

Is there something left for me to do to get this PR merged?
Would be great to have it in the next release.

@dlorenc dlorenc merged commit 6501693 into sigstore:main Jun 30, 2022
@github-actions github-actions bot added this to the v1.10.0 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cosign attest --replace fails to create attestations on random.Image() generated images
3 participants