Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosigned] Rename cosigned references to policy-controller #1893

Merged
merged 5 commits into from
May 20, 2022

Conversation

hectorj2f
Copy link
Contributor

Summary

This PR renames all the references of cosigned to policy-controller, as decided in sigstore/TSC#9 and discussed in #1892.

Ticket Link

Fixes #1892

Release Note

cosigned: rename cosigned references to its new name policy-controller.

@hectorj2f hectorj2f requested a review from vaikas May 18, 2022 12:59
@hectorj2f hectorj2f self-assigned this May 18, 2022
cmd/cosign/policy_webhook/main.go Outdated Show resolved Hide resolved
config/100-namespace.yaml Outdated Show resolved Hide resolved
@adamd-vmw
Copy link

Thank you @hectorj2f and @imjasonh !

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #1893 (a98b0b2) into main (4a9a642) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1893   +/-   ##
=======================================
  Coverage   34.03%   34.03%           
=======================================
  Files         153      153           
  Lines        9934     9934           
=======================================
  Hits         3381     3381           
  Misses       6173     6173           
  Partials      380      380           
Impacted Files Coverage Δ
cmd/cosign/policy_webhook/main.go 0.00% <0.00%> (ø)
cmd/cosign/webhook/main.go 0.00% <0.00%> (ø)
...s/policy/v1alpha1/clusterimagepolicy_conversion.go 79.41% <ø> (ø)
...pis/policy/v1alpha1/clusterimagepolicy_defaults.go 100.00% <ø> (ø)
...g/apis/policy/v1alpha1/clusterimagepolicy_types.go 0.00% <ø> (ø)
...s/policy/v1alpha1/clusterimagepolicy_validation.go 93.75% <ø> (ø)
pkg/apis/policy/v1alpha1/register.go 0.00% <ø> (ø)
pkg/apis/policy/v1alpha1/zz_generated.deepcopy.go 0.00% <ø> (ø)
...is/policy/v1beta1/clusterimagepolicy_conversion.go 100.00% <ø> (ø)
...apis/policy/v1beta1/clusterimagepolicy_defaults.go 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a9a642...a98b0b2. Read the comment docs.

@dlorenc
Copy link
Member

dlorenc commented May 20, 2022

This looks good but has a small merge conflict still.

@hectorj2f hectorj2f force-pushed the rename_cosigned_policy_controller branch from 64b32bc to 7852be1 Compare May 20, 2022 17:03
@hectorj2f hectorj2f requested a review from coyote240 May 20, 2022 17:06
coyote240
coyote240 previously approved these changes May 20, 2022
Copy link

@coyote240 coyote240 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On find/replace error, otherwise as good as I can anticipate.

@hectorj2f hectorj2f force-pushed the rename_cosigned_policy_controller branch from 7852be1 to a98b0b2 Compare May 20, 2022 17:30
@hectorj2f hectorj2f requested a review from coyote240 May 20, 2022 17:35
@dlorenc dlorenc merged commit b0fffb2 into sigstore:main May 20, 2022
@github-actions github-actions bot added this to the v1.9.0 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change 'cosigned' name to 'policy-controller'
6 participants