Add function to explicitly request a certain provider #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
reviewed
May 4, 2022
pkg/providers/interface.go
Outdated
Comment on lines
87
to
88
| // ExplicitProvide fetches an OIDC token from the specified provider | ||
| func ExplicitProvide(ctx context.Context, audience, provider string) (string, error) { |
There was a problem hiding this comment.
nit: maybe something like ProvideFrom(ctx, provider) that returns the Provider?
There was a problem hiding this comment.
This would let folks look it up and check enabled themselves, which could be useful.
There was a problem hiding this comment.
good call, updated!
Signed-off-by: Priya Wadhwa <[email protected]>
mattmoor
approved these changes
May 4, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Signed-off-by: Priya Wadhwa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use this library in Chains to request a token via SPIRE, but it keeps defaulting to google GKE credentials (which just happens to come first in the list via
providers.Provide). With this function, I can explicitly call out spiffe as the desired provider.Signed-off-by: Priya Wadhwa [email protected]
Summary
Ticket Link
Fixes
Release Note