Remove the dependency on v1alpha1.Identity which brings in unnecessary k8s deps. #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1790 +/- ##
==========================================
- Coverage 31.43% 31.42% -0.02%
==========================================
Files 144 144
Lines 8890 8893 +3
==========================================
Hits 2795 2795
- Misses 5758 5760 +2
- Partials 337 338 +1
Continue to review full report at Codecov.
|
unnecessary k8s libraries. Brought up as an issue that was merged in: sigstore#1759 Signed-off-by: Ville Aikas <[email protected]>
dlorenc
approved these changes
Apr 22, 2022
mtrmac
reviewed
Apr 22, 2022
|
Thanks @mtrmac for checking that it indeed fixed the import issues :) |
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…1790) unnecessary k8s libraries. Brought up as an issue that was merged in: sigstore#1759 Signed-off-by: Ville Aikas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ville Aikas [email protected]
Summary
In #1759 I reused a struct from v1alpha1.Identity, which I didn't realize brought
deps to k8s where there shouldn't have been any. This rectifies this
by re-creating that struct here.
Ticket Link
Fixes
Release Note