Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate issuer/subject regexp in validate webhook. #1761

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Apr 14, 2022

Signed-off-by: Ville Aikas [email protected]

Summary

Followup to #1759 validate the issuer/subject regexp in the validating webhook + tests.

Ticket Link

Fixes

Release Note

 - validate issuer/subject in the CIP validating webhook.

@vaikas vaikas requested a review from mattmoor April 14, 2022 18:38
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #1761 (0d2e812) into main (0c232da) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1761      +/-   ##
==========================================
+ Coverage   30.55%   30.59%   +0.04%     
==========================================
  Files         143      143              
  Lines        8651     8657       +6     
==========================================
+ Hits         2643     2649       +6     
  Misses       5709     5709              
  Partials      299      299              
Impacted Files Coverage Δ
...cosigned/v1alpha1/clusterimagepolicy_validation.go 91.89% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c232da...0d2e812. Read the comment docs.

@vaikas vaikas enabled auto-merge (squash) April 14, 2022 19:11
@vaikas vaikas merged commit 9516998 into sigstore:main Apr 14, 2022
@github-actions github-actions bot added this to the v1.8.0 milestone Apr 14, 2022
@vaikas vaikas deleted the validate-identities-regexp branch April 14, 2022 19:29
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants