Fix handling of policy in verify-attestation #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1672 +/- ##
==========================================
+ Coverage 28.08% 29.34% +1.26%
==========================================
Files 139 141 +2
Lines 8025 8372 +347
==========================================
+ Hits 2254 2457 +203
- Misses 5523 5646 +123
- Partials 248 269 +21
Continue to review full report at Codecov.
|
Previously, the code was comparing a predicate URI against a payload type. This is never expected to match. Modify the code to extract the actual predicate type from within the payload so the verification can be done successfully. Signed-off-by: Luiz Carvalho <[email protected]>
lcarva
force-pushed
the
handle-undefined-rego
branch
2 times, most recently
from
7969eaf
to
89219e2
Compare
lcarva
commented
Mar 29, 2022
This commit addresses multiple issues when applying a rego policy against the payload of an attestation. 1. If `data.signature.deny` evaluated to `true`, the policy verification would pass. This is obviously unexpected. The code now looks for `data.signature.allow` instead, and expects it to be `true`. 2. If a query result returned an undefined results, the policy verification would pass. The code now explicitly checks for this condition and ensure that if `ResultSet.IsAllowed()` returns `false`, the policy verification also fails. 3. Improve error messages to assist user in defining correct variable name and type. 4. Add unit tests to validate behavior and prevent breaking changes in the future. Signed-off-by: Luiz Carvalho <[email protected]>
lcarva
force-pushed
the
handle-undefined-rego
branch
from
89219e2
to
90009e9
Compare
dlorenc
approved these changes
Mar 30, 2022
|
Thanks @lcarva for doing this! I'm going to merge this so I can start adding the e2e tests in a followup. |
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Fix sanity checks during policy processing Previously, the code was comparing a predicate URI against a payload type. This is never expected to match. Modify the code to extract the actual predicate type from within the payload so the verification can be done successfully. Signed-off-by: Luiz Carvalho <[email protected]> * Fix rego policy verification This commit addresses multiple issues when applying a rego policy against the payload of an attestation. 1. If `data.signature.deny` evaluated to `true`, the policy verification would pass. This is obviously unexpected. The code now looks for `data.signature.allow` instead, and expects it to be `true`. 2. If a query result returned an undefined results, the policy verification would pass. The code now explicitly checks for this condition and ensure that if `ResultSet.IsAllowed()` returns `false`, the policy verification also fails. 3. Improve error messages to assist user in defining correct variable name and type. 4. Add unit tests to validate behavior and prevent breaking changes in the future. Signed-off-by: Luiz Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The first commit fixes the sanity checks during policy processing. Previously, the code was comparing a predicate URI against a payload type. This is never expected to match.
The code was modifying to extract the actual predicate type from within the payload so the verification can be done successfully.
The second commit addresses multiple issues when applying a rego policy against the payload of an attestation:
data.signature.denyevaluated totrue, the policy verification would pass. This is obviously unexpected. The code now looks fordata.signature.allowinstead, and expects it to betrue.condition and ensures that if
ResultSet.Allowed()returnsfalsethe policy verification also fails.Release Note