tests: /bin/bash -> /usr/bin/env bash
#1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses `bash` from the user's `$PATH`, which is (usually) preferable to hardcoding a particular `bash` location: https://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-my Selfishly, without this change these scripts don't work on NixOS. Signed-off-by: Zachary Newman <[email protected]>
dlorenc
approved these changes
Feb 16, 2022
|
Filed #1471 for the flaky CI |
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
This uses `bash` from the user's `$PATH`, which is (usually) preferable to hardcoding a particular `bash` location: https://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-my Selfishly, without this change these scripts don't work on NixOS. Signed-off-by: Zachary Newman <[email protected]>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
This uses `bash` from the user's `$PATH`, which is (usually) preferable to hardcoding a particular `bash` location: https://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-my Selfishly, without this change these scripts don't work on NixOS. Signed-off-by: Zachary Newman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This uses
bashfrom the user's$PATH, which is (usually) preferable to hardcoding a particularbashlocation: https://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-mySelfishly, without this change these scripts don't work on NixOS.
Ticket Link
Fixes N/A
Release Note