Do not require multiple Fulcio certs in the TUF root #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asraa
reviewed
Dec 16, 2021
| if err := tuf.GetTarget(ctx, fulcioTarget, &buf); err != nil { | ||
| panic(errors.Wrap(err, "creating root cert pool")) | ||
| } | ||
| buf := tuf.ByteDestination{Buffer: &bytes.Buffer{}} |
There was a problem hiding this comment.
WDYT about keeping the previous code and use a bool to panic if one of the targets wasn't added?
(as in gracefully fail, just fail when none of the errors were nil)
There was a problem hiding this comment.
make sense, I will update the patch
cosign requires both fulcio.crt.pem and fulcio_v1.crt.pem in the TUF root which doesn't make sense when using local TUF. fulcio_v1.crt.pem was added in the embedded TUF in order to support Fulcio v1 but it shouldn't be required when users initialize cosign with their own TUF repo. Closes: sigstore#1229 Signed-off-by: Radoslav Gerganov <[email protected]>
rgerganov
force-pushed
the
fulcio-tuf
branch
from
6a20e8d
to
ee09677
Compare
dlorenc
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cosign requires both fulcio.crt.pem and fulcio_v1.crt.pem in the TUF
root which doesn't make sense when using local TUF. fulcio_v1.crt.pem
was added in the embedded TUF in order to support Fulcio v1 but it
shouldn't be required when users initialize cosign with their own TUF
repo.
Closes: #1229
Signed-off-by: Radoslav Gerganov [email protected]