Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update oidc ci tests #1029

Merged
merged 1 commit into from
Nov 11, 2021
Merged

ci: update oidc ci tests #1029

merged 1 commit into from
Nov 11, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 11, 2021

Summary

the oidc tests are broken after we make the changes in how to build the images using ko and adding some definitions

Ticket Link

n/a

Release Note

ci: update oidc ci tests

Signed-off-by: Carlos Panato <[email protected]>
@cpanato
Copy link
Member Author

cpanato commented Nov 11, 2021

not sure if we want to continue to push to GitHub the images or to gcr

@dlorenc dlorenc merged commit ff2104c into sigstore:main Nov 11, 2021
@github-actions github-actions bot added this to the v1.4.0 milestone Nov 11, 2021
@cpanato cpanato deleted the fixci branch November 11, 2021 13:33
@cpanato
Copy link
Member Author

cpanato commented Nov 11, 2021

@cpanato
Copy link
Member Author

cpanato commented Nov 11, 2021

humm

cosign sign -a sha=ITHUB_SHA -a run_id=1448802534 -a run_attempt=1 ghcr.io/sigstore/cosign/cosign:ITHUB_SHA

will make a follow up

@cpanato cpanato mentioned this pull request Nov 11, 2021
@cpanato cpanato modified the milestones: v1.4.0, v1.3.1 Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants